Support TLS Server/Client certificates read from a file, and refreshe… #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
reviewed
Oct 28, 2022
joeljeske
force-pushed
the
tls-rotate
branch
4 times, most recently
from
c9e9456
to
5f49aeb
Compare
joeljeske
force-pushed
the
tls-rotate
branch
2 times, most recently
from
9b7928e
to
a732c0e
Compare
EdSchouten
reviewed
Oct 31, 2022
EdSchouten
reviewed
Nov 2, 2022
pkg/util/tls_test.go
Outdated
| @@ -207,6 +267,14 @@ func TestTLSConfigFromClientConfiguration(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestTLSConfigFromServerConfiguration(t *testing.T) { | |||
| tempDir := t.TempDir() | |||
| exampleCertFile := tempDir + "/example-cert.pem" | |||
There was a problem hiding this comment.
Whoops! It looks like we can also use filepath.Join() here.
|
Thanks Ed! Very helpful tips, I appreciate it. Changes are made! :) |
EdSchouten
approved these changes
Nov 2, 2022
pkg/util/tls_test.go
Outdated
| @@ -207,6 +267,14 @@ func TestTLSConfigFromClientConfiguration(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestTLSConfigFromServerConfiguration(t *testing.T) { | |||
| tempDir := t.TempDir() | |||
| exampleCertFile := tempDir + "/example-cert.pem" | |||
There was a problem hiding this comment.
Whoops! It looks like we can also use filepath.Join() here.
…d on an interval.
Incompatible Changes:
This change moves the existing `{client,server}_certificate` and `{client,server}_private_key` into `{client,server}_key_pair_data.certificate` and `{client,server}_key_pair_data.private_key`
This change adds an alternate strategy for specifying certificates/private keys by using `{client,server}_key_pair_files.certificate` and `{client,server}_key_pair_files.private_key` which should reference PEM files on disk. A refresh_interval must also be specified to dictate the interval at which the files should be read and used in place of the existing certificate/key if such files have been changed.
In kubernetes for example, this allows a side-car to rotate certificate based on user's needs.
|
Ah! So sorry, fixed now :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d on an interval.
Incompatible Changes:
This change moves the existing
{client,server}_certificateand{client,server}_private_keyinto{client,server}_key_pair.inline.certificateand{client,server}_key_pair.inline.private_keyThis change adds an alternate strategy for specifying certificates/private keys by using
{client,server}_key_pair.files.certificate_pathand{client,server}_key_pair.files.private_key_pathwhich should reference PEM files on disk. A refresh_interval must also be specified to dictate the interval at which the files should be read and used in place of the existing certificate/key if such files have been changed.In kubernetes for example, this allows a side-car to rotate certificate based on user's needs.