Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix downloaded artifact permissions #2894

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix downloaded artifact permissions #2894

merged 1 commit into from
Jul 22, 2024

Conversation

DrJosh9000
Copy link
Contributor

Description

The change from os.Create to os.CreateTemp changed the file permissions of the created file (from 0o666 to 0o600). This was unintentional.

Context

#2878

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 requested a review from wolfeidau July 22, 2024 00:09
wolfeidau
wolfeidau approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 looks good

@DrJosh9000 DrJosh9000 merged commit 33e6f61 into main Jul 22, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the artifact-integrity branch July 22, 2024 00:39
This was referenced Jul 22, 2024
Merged
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @wolfeidau