k8s: Unconditionally set BUILDKITE_AGENT_ACCESS_TOKEN #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fix-k8s-access-token
branch
from
82d2cc0 to
7da8091
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unconditionally set
BUILDKITE_AGENT_ACCESS_TOKEN, regardless of whether it is already set.This matches pre-#2851 behaviour.
Context
Manually setting
BUILDKITE_AGENT_ACCESS_TOKENwithin the command container was found to break uses of many agent subcommands (e.g.meta-data set) within jobs run on newer agents (v3.74.1 and later) in the k8s stack.https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Pipelines-Escalations_su7FT#Pipelines-Escalations-Board_tu__K/r597&view=modal
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)