Increase AMI garbage collection to 100 images per run #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started with 10 while I was building the pipeline, mainly to limit the blast radius if I accidentally deregistered the wrong images. The pipeline is now up and running and I've manually run it a few times. It's working just as planned, and only un-versioned images created more than a year ago are being deregistered. I'm confident we can increase this to a higher number now. Looking at the logs for some regions, I can see most have 900-1200 images in them. Once this chance merges, I'll do a couple of manually runs to cut those numbers down by a few hundred, then we can rely on the weekly scheduled build to keep the number down over time.
DrJosh9000
approved these changes
Dec 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with 10 while I was building the pipeline, mainly to limit the blast radius if I accidentally deregistered the wrong images.
The pipeline is now up and running and I've manually run it a few times. It's working just as planned, and only un-versioned images created more than a year ago are being deregistered.
I'm confident we can increase this to a higher number now. Looking at the logs for some regions, I can see most have 900-1200 images in them. Once this chance merges, I'll do a couple of manually runs to cut those numbers down by a few hundred, then we can rely on the weekly scheduled build to keep the number down over time.