Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Issue #249] Adds local-path-destination-image flag #325

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

fcaroline2020
Copy link
Contributor

local-path-destination-image flag for creating images with user specified source code image repo location

`local-path-destination-image` flag for creating images with user specified source code image repo location

Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
@fcaroline2020 fcaroline2020 requested a review from a team as a code owner July 21, 2023 16:21
Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
@fcaroline2020 fcaroline2020 linked an issue Aug 1, 2023 that may be closed by this pull request
@chenbh
Copy link
Contributor

chenbh commented Aug 1, 2023

btw, you can leave a "fixes #249" in the PR body and GitHub is smart enough to automatically link the issue

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

…ate and save

Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
Copy link
Contributor

@chenbh chenbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenbh chenbh merged commit f5cac04 into main Aug 8, 2023
@chenbh chenbh deleted the Issue-249-local-source-image branch August 8, 2023 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--local-path should not assume a repository name
2 participants