Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generate docker config in temp dir during image signing #1157

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

tomkennedy513
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1157 (61baf85) into release/v0.7.x (cf95c76) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release/v0.7.x    #1157      +/-   ##
==================================================
- Coverage           70.58%   70.56%   -0.03%     
==================================================
  Files                 121      121              
  Lines                5729     5724       -5     
==================================================
- Hits                 4044     4039       -5     
  Misses               1311     1311              
  Partials              374      374              
Impacted Files Coverage Δ
pkg/apis/build/v1alpha2/build_pod.go 98.65% <ø> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenbh
Copy link
Contributor

chenbh commented Feb 27, 2023

If i'm understanding this correctly, this is to deal with platforms cough openshift cough where security policies are in place that forces every pod to run under a random uid/gid. In such platforms, we can't chmod the home directory and we can't explicitly configure the running user, so any attempts to write the .dockerconfig.json will fail.

So the solution here is to generate a tempdir and set $DOCKER_CONFIG env var (which supported in ggcr)

@tomkennedy513 tomkennedy513 merged commit 0a0c184 into release/v0.7.x Feb 27, 2023
@tomkennedy513 tomkennedy513 deleted the rebase-pod-fix branch February 27, 2023 20:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants