Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Image status details #1176

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

menehune23
Copy link
Contributor

From looking at the code and testing on a cluster, the existing docs seem to be incorrect as they use Ready on the Image resource (the Build resource does use Succeeded though)

@tomkennedy513
Copy link
Collaborator

Hey @menehune23, Thank you for fixing this! Can you rebase this pr onto main ?

@menehune23
Copy link
Contributor Author

@tomkennedy513 Done! Though it looks like CI is failing for some other reason. Do you have a way to retrigger it?

@codecov-commenter
Copy link

Codecov Report

Merging #1176 (e9c7479) into main (4b61ffb) will not change coverage.
The diff coverage is n/a.

❗ Current head e9c7479 differs from pull request most recent head 31479f6. Consider uploading reports for the commit 31479f6 to get more accurate results

@@           Coverage Diff           @@
##             main    #1176   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files         132      132           
  Lines        6671     6671           
=======================================
  Hits         4672     4672           
  Misses       1570     1570           
  Partials      429      429           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomkennedy513
Copy link
Collaborator

@tomkennedy513 Done! Though it looks like CI is failing for some other reason. Do you have a way to retrigger it?

I think it is due to how github action secrets work with forks. I am changing the ci task now

@tomkennedy513 tomkennedy513 merged commit 2acd2bb into buildpacks-community:main Apr 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants