Cleaning up various files and fixing runtime errors raised during testing #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taswartz
reviewed
May 3, 2023
| @@ -31,12 +31,12 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-jdbc</artifactId> | |||
| <!-- TODO: Includes Spring-starter-logging. Uncomment to use log4j2--> | |||
| <!-- <exclusions>--> | |||
There was a problem hiding this comment.
This would be utilizing log4j2 now? Can we change the comment above it?
taswartz
reviewed
May 3, 2023
taswartz
reviewed
May 3, 2023
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.TimeZone; | ||
| import java.util.*; |
There was a problem hiding this comment.
Usually standard to try to not import all of java util packages and only the ones we need
There was a problem hiding this comment.
This is my IDE automatically doing this. I'll disable the option.
|
This all looks good to me! Let me know if you decide to fix anything else up, but I think we are ready to ship this! |
taswartz
reviewed
May 4, 2023
There was a problem hiding this comment.
Can we also remove the other extraneous comments I left in the pom.xml file? (i.e line 69 and the other TODO)
- Cleanup TODOs - Fix StandardJpaDao.getTotal - Remove Autowired annotation in AbstractWorkflowAction.java in favor of explicit applicationContext usage
taswartz
added a commit
that referenced
this pull request
Jun 9, 2023
* Upgrade to Java 17 * Migrating entity changer from groovy to java (#183) * First working java17 commit * Adding the rest prefixes for the rest endpoints * Chaning applicable functions to lambdas and updating logging to log4j2 for classes not using it * Adding security tools * Adding ValidationMessages, externalizing hibernate properties, removing unused values from AppSettings * Deleting the picker folder * Fixing up pom issues + thread ID logging + notes on json converter * Adding some TODOs and making all ApplicationSettings final * Adding some java docs to bean config + changing ApplicationSettings * Changing ApplicationSettings from class to a record * Replacing Slf4j annotation with Log4j2 * Removing solo standardSub config code + removing joda time + removing security files * Refactoring cron trigger configuration * Configuring beans for restTemplate + multipart resolver + locale + removing jsonconverter function * Migrate EntityChanger from groovy to java * Refactor java 9 deprecated code. Also made use of PropertyDescriptors instead of manually looking for getter/setters * Enhanced error messages * Adding null assertions in Unit test * Testing enhancements - Improved coverage - Separated tests into their own, atomic methods - Make better use of `@Before` --------- Co-authored-by: Trevor Swartz <trevor.swartz@bullhorn.com> * Upgrading JUnit 4 -> JUnit5 (#177) * Updagrading from JUnit 4 to JUnit 5 * PS-31586: Fixing up compile + runtime errors in testing * PS-31586: Cleaning up unused imports and some unnecessary config * PS-31586: Updating DataSource in the TestConfig * PS-31586: Adding testing scope --------- Co-authored-by: Matthew Davino <matthew.davino@bullhorn.net> Co-authored-by: Trevor Swartz <swartz.trevor24@gmail.com> Co-authored-by: Trevor Swartz <trevor.swartz@bullhorn.com> * Updating StandardEntityChangerTest to JUnit 5 (#184) * ARPBE-72: Adding latest features to README.md (#181) * First working java17 commit * Adding the rest prefixes for the rest endpoints * Chaning applicable functions to lambdas and updating logging to log4j2 for classes not using it * Adding security tools * Adding ValidationMessages, externalizing hibernate properties, removing unused values from AppSettings * Deleting the picker folder * Fixing up pom issues + thread ID logging + notes on json converter * Adding some TODOs and making all ApplicationSettings final * Adding some java docs to bean config + changing ApplicationSettings * Changing ApplicationSettings from class to a record * Replacing Slf4j annotation with Log4j2 * Removing solo standardSub config code + removing joda time + removing security files * Refactoring cron trigger configuration * Configuring beans for restTemplate + multipart resolver + locale + removing jsonconverter function * Migrate EntityChanger from groovy to java * Refactor java 9 deprecated code. Also made use of PropertyDescriptors instead of manually looking for getter/setters * Enhanced error messages * Adding null assertions in Unit test * Testing enhancements - Improved coverage - Separated tests into their own, atomic methods - Make better use of `@Before` * ARPBE-72: Adding latest features to README.md * ARPBE-72: Adding latest features to README.md * ARPBE-72: Fixing some grammar and form trigger info * ARPBE-72: Improving Scheduled Task documentation * Adding documentation on nightly tasks/cron jobs. --------- Co-authored-by: Trevor Swartz <trevor.swartz@bullhorn.com> * Configuring the dateLastModified task processor for java config (#185) * Configuring the dateLastModified task processor for java config * Ameding DLM code (#3) * Ameding DLM code * Converting DateLastModifiedEventProcessing into a cron job using Spring boot * Removing DLM bean reference in ScheduledEventConfig * Restoring ScheduledEventConfig to what it was before DLM amends (#4) * Removing blank space --------- Co-authored-by: Tomás El Fakih <tomaselfakih@gmail.com> * Fixing @scheduled method documentation and proper initialization (#188) * Cleaning up various files and fixing runtime errors raised during testing (#190) * Cleaning up various files and fixing runtime errors raised during testing * Cleanup tasks pt2: - Cleanup TODOs - Fix StandardJpaDao.getTotal - Remove Autowired annotation in AbstractWorkflowAction.java in favor of explicit applicationContext usage * Explicit imports in Utility as per code review request * Include log4j logmanager + Changing main class to 'Application' (#192) * Adding log4j api to allow for the use of LogManager + Changing main class to Application * Upgrading sdk-rest version to 2.0.1 (#193) --------- Co-authored-by: Tomás El Fakih <tomaselfakih@gmail.com> Co-authored-by: mattdavinobh <122385883+mattdavinobh@users.noreply.github.com> Co-authored-by: Matthew Davino <matthew.davino@bullhorn.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few tests we noticed some runtime errors in the Spring boot application. Also we are now aware we can clean up some unnecessary files. This PR is a compilation of various changes