Fix StandardEntityChanger to support String casting when possible #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taswartz
reviewed
Sep 28, 2023
src/main/java/com/client/core/base/tools/entitychanger/impl/StandardEntityChanger.java
Outdated
Show resolved
Hide resolved
taswartz
reviewed
Sep 29, 2023
src/main/java/com/client/core/base/tools/entitychanger/impl/StandardEntityChanger.java
Outdated
Show resolved
Hide resolved
taswartz
reviewed
Sep 29, 2023
| entityChanger.setField(testBullhornEntity, "simpleStringContainer", "Test"); | ||
| assertEquals("Test", testBullhornEntity.getAdditionalProperties().get("simpleStringContainer")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we add a test like the following?
@Test
public void setFieldSavesFailedCastsToAdditionalPropertiesIfAvailable() {
EntityChanger entityChanger = new StandardEntityChanger();
entityChanger.setField(testBullhornEntity, "simpleStringContainer.someOtherEntity.id", "Test");
assertEquals("Test", testBullhornEntity.getAdditionalProperties().get("simpleStringContainer.someOtherEntity.id"));
}
I think this will actually throw an error in our case
Co-authored-by: Trevor Swartz <swartz.trevor24@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
StandardEntityChangerwill fail to set text fields if the incoming parameter is not ofStringtype. This PR fixes this to at least guaranteeInteger/Doublecast support, however every data type should be cast-able toStringvia theObejct.toString()method.