Skip to content

Current master / develop branch don't compile #148

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
2 tasks
ZzAve opened this issue Dec 31, 2022 · 3 comments
Closed
2 tasks

Current master / develop branch don't compile #148

ZzAve opened this issue Dec 31, 2022 · 3 comments

Comments

@ZzAve
Copy link

ZzAve commented Dec 31, 2022

Steps to reproduce:

  1. Run ./gradlew clean build

What should happen:

  1. A successful build

What happens:

❯ gradle clean build
executing gradlew instead of gradle

> Task :compileJava
/Users/juliusvandis/IdeaProjects/Personal/sdk_java/src/main/java/com/bunq/sdk/model/generated/endpoint/CurrencyCloudBeneficiaryRequirement.java:53: error: cannot find symbol
  private List<CurrencyCloudBeneficiaryRequirementField> allField;
               ^
  symbol:   class CurrencyCloudBeneficiaryRequirementField
  location: class CurrencyCloudBeneficiaryRequirement
/Users/juliusvandis/IdeaProjects/Personal/sdk_java/src/main/java/com/bunq/sdk/model/generated/endpoint/CurrencyCloudBeneficiaryRequirement.java:97: error: cannot find symbol
  public List<CurrencyCloudBeneficiaryRequirementField> getAllField() {
              ^
  symbol:   class CurrencyCloudBeneficiaryRequirementField
  location: class CurrencyCloudBeneficiaryRequirement
/Users/juliusvandis/IdeaProjects/Personal/sdk_java/src/main/java/com/bunq/sdk/model/generated/endpoint/CurrencyCloudBeneficiaryRequirement.java:101: error: cannot find symbol
  public void setAllField(List<CurrencyCloudBeneficiaryRequirementField> allField) {
                               ^
  symbol:   class CurrencyCloudBeneficiaryRequirementField
  location: class CurrencyCloudBeneficiaryRequirement
Note: /Users/juliusvandis/IdeaProjects/Personal/sdk_java/src/main/java/com/bunq/sdk/security/SecurityUtils.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.8.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 4s
2 actionable tasks: 2 executed

Traceback

SDK version and environment

  • Tested on 1.14.1
  • Sandbox
  • Production

N/A

Response id

N/A

Extra info:

It seems that develop cannot be build for some time already. Earliest point I could find was 1.18.12.49. There might be some issue with the generated code and a automated build pipeline that 'just' updates the generated files, and performs a release, without running a full build?

ZzAve added a commit to ZzAve/bunq_sdk_java that referenced this issue Dec 31, 2022
To me it's somewhat unclear why it doesn't work, seems that generated objects have changed and actually break some things?
With these changes, at least everything compiles, and all test pass

Applied the changed related to `ShareInviteBankInquiry` and `ShareDraftInquiry`
@two-trick-pony-NL
Copy link
Member

👋 Hey @ZzAve

I work at bunq and am currently reviewing the bunq API docs, open issues and SDK’s and came across your issue. I know it’s been open for a while, and I’d love to understand how it’s impacting you. Beyond the obvious -fixing this issue-, what else could we do to improve your experience with our API?

If you want to share your thoughts on how we can improve on our public API:

📅 I'd love to schedule a 15 minute interview to understand your needs through: Calendly
💬 Or if you don't have time for a call, you can give us some general feedback through this form

Your feedback will go straight to our product team! 🚀

@ZzAve
Copy link
Author

ZzAve commented Mar 6, 2025

Hi @two-trick-pony-NL ,

Thank you for taking the time to start looking into the Bunq SDKs. It's been quite some time since there has been any progress on any of them, and I feel that these have been neglected for quite some time.

I've got some ideas on how to improve the maintainability of the SDKs, including reducing the amount of dependencies, without having to compromise on the quality of the SDK. The most important part of the sdk is the handshake with bunq, and enabling the use of the public facing api, with as little code as possible. I'd like to take you up on your offer to have a quick chat and scheduled a meeting for tomorrow!

@two-trick-pony-NL
Copy link
Member

Hi Julius, I emailed you too! We're closing this issue as it's tied to an older version of our SDKs, and we've since completely revamped them as part of bunq Update 28.

This is a fresh start—we've tested the new SDKs extensively, and we’ll be putting them to the test again during our upcoming hackathon this Friday, where we’ll fix idiosyncrasies on the spot. (You’re welcome to join us!)

If this issue (or a new one) shows up with the updated SDKs, feel free to reopen or file a new report—we're happy to jump on it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants