Cannot list payments due to geolocation. (Bunq/sdk_java#46 ) #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickdw1991 all yours please 👀 |
patrickdw1991
requested changes
Jan 2, 2018
| @@ -29,7 +29,7 @@ public void write(JsonWriter output, BigDecimal value) throws IOException { | |||
|
|
|||
| @Override | |||
| public BigDecimal read(JsonReader input) throws IOException { | |||
| if (input.peek() == JsonToken.STRING) { | |||
| if (input.peek() == JsonToken.NUMBER) { | |||
There was a problem hiding this comment.
Why not just make this handle both strings and numbers?
if (type = number) {
new bigdecimal(getDoubleValue)
} else if (type = string) {
new bigdecimal(getStringValue)
} else {
null
}
patrickdw1991
requested changes
Jan 2, 2018
| JsonToken type = input.peek(); | ||
|
|
||
| if (type == JsonToken.NUMBER) { | ||
| return new BigDecimal(input.nextInt()); |
There was a problem hiding this comment.
Why nextInt instead of double? Int will not return you the fractions.
added 5 commits
January 2, 2018 14:00
OGKevin
force-pushed
the
bunq/sdk_java#46-Cannot-list-payments-due-to-geolocation
branch
from
ba7d47e to
bb02f22
Compare
patrickdw1991
approved these changes
Jan 2, 2018
andrederoos
approved these changes
Jan 2, 2018
|
@andrederoos merging! |
OGKevin
deleted the
bunq/sdk_java#46-Cannot-list-payments-due-to-geolocation
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46