Fixed MonetaryAccountReferenceTypeAdapter to output proper value. (bunq/sdk_java#49) #68
Conversation
|
@patrickdw1991 all yours please 👀 |
| out.nullValue(); | ||
| } else if (value.getPointer() == null) { |
There was a problem hiding this comment.
Wouldn't it be nicer to check if the value.getLabelMonetaryAccount is not null?
There was a problem hiding this comment.
But thats already done above ? if (value == null || value.isAllFieldNull()) { via isAllFieldNull ? 🤔
There was a problem hiding this comment.
The statements that follow is purely to know which one to use as both cant be populated with data.
There was a problem hiding this comment.
There you check if all fields are null. Here you check if the pointer is null. Wouldn't it be nicer to check:
else if (value.getLabelMonetaryAccount() != null) {
Because in theory it doesn't mean that if not all fields are null and the pointer is null that the Monetary account label is not null.
There was a problem hiding this comment.
😮 😁 🤦♂️ makes sense.
|
@andrederoos all yours please 👀 |
andrederoos
deleted the
bunq/sdk_java#49-getCounterpartyAlias-returns-null-when-printed
branch
This PR closes/fixes the following issues: