Fix for Issue 153 #155
Merged
Fix for Issue 153 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore removing it and recalculating the heights of the sections. If we do not do this the users who do not have graphics devices will always have their height preferences ignored since an assumption was made that the graphics device existed in the layout. Closes issue #153
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users preferences were being ignored on systems without GPUs because the section heights would be recomputed to consider the absence of a graphics section. This PR checks to see if the graphics section exists in the layout. If it does, then we will need to recompute the layout considering it's absence, otherwise we do not.
This restores listening to the users preferences for dimensions of the sections.