Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename wasi:config/runtime to wasi:config/store #100

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Oct 9, 2024

The wasi:config/runtime interface was renamed upstream to wasi:config/store. The repository was also renamed from github.com/WebAssembly/wasi-runtime-config to
github.com/WebAssembly/wasi-config, cementing the shift away from "runtime".

This commit replaces the support for the runtime interface and replaces it with the functionally equivalent store interface. It also removes references to "runtime" config in the readme and CLI help.

Since the interface is still draft and support labeled as experimental, backwards compatibility is not preserved.

Refs WebAssembly/wasi-config#17 bytecodealliance/wasmtime#9404

@scothis
Copy link
Contributor Author

scothis commented Oct 9, 2024

Keeping as a draft until the wasmtime changes land in a proper release. Although since these are only dev dependencies I wouldn't object to merging earlier if it's desired.

@guybedford
Copy link
Collaborator

This has now landed in Wasmtime 26 I believe, shall we go ahead and merge?

@scothis
Copy link
Contributor Author

scothis commented Oct 29, 2024

This has now landed in Wasmtime 26 I believe, shall we go ahead and merge?

Wasmtime 26 still has wasi:config/runtime, 27 will have the updated interface.

The `wasi:config/runtime` interface was renamed upstream to
`wasi:config/store`. The repository was also renamed from
github.com/WebAssembly/wasi-runtime-config to
github.com/WebAssembly/wasi-config, cementing the shift away from
"runtime".

This commit replaces the support for the runtime interface and replaces
it with the functionally equivalent store interface. It also removes
references to "runtime" config in the readme and CLI help.

Since the interface is still draft and support labeled as experimental,
backwards compatibility is not preserved.

Signed-off-by: Scott Andrews <scott@andrews.me>
@scothis scothis marked this pull request as ready for review November 20, 2024 21:40
@scothis
Copy link
Contributor Author

scothis commented Nov 20, 2024

@guybedford Wasmtime 27 was released today. Rebased and updated.

Also needed to bump the rust version. I picked the last nightly that supports the wasm32-wasi target.

@guybedford guybedford merged commit 0948ede into bytecodealliance:main Nov 20, 2024
2 checks passed
@guybedford
Copy link
Collaborator

Great, thank you!

@scothis scothis deleted the wasi-config-store branch November 20, 2024 23:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants