Add loongarch64 support #1086
Add loongarch64 support #1086
Conversation
|
Rustix doesn't use |
|
@sunfishcode Hi, I found that getrlimit and setrlimit functions have been implemented using prlimit64 in the file src/backend/linux_raw/process/syscalls.rs. Maybe loongarch64 does not need additional processing. But I am not sure which file the following code calls in the file src/process/rlimit.rs: Because both src/backend/linux_raw/process/syscalls.rs and src/backend/libc/process/syscalls.rs define the two functions setrlimit and getrlimit. |
Rustix has two "backends", one that uses libc calls and one that uses raw linux syscalls. The code in src/process/rlimit.rs will call either the code in src/backend/linux_raw/process/syscalls.rs or src/backend/libc/process/syscalls.rs depending on which backend the user has configured. However, I'd expect both backends to work with loongarch64, because rustix doesn't use the |
| @@ -161,6 +162,7 @@ pub fn fchown<Fd: AsFd>(fd: Fd, owner: Option<Uid>, group: Option<Gid>) -> io::R | |||
| /// [Linux]: https://man7.org/linux/man-pages/man2/fstat.2.html | |||
| /// [`Mode::from_raw_mode`]: Mode::from_raw_mode | |||
| /// [`FileType::from_raw_mode`]: crate::fs::FileType::from_raw_mode | |||
| #[cfg(not(target_arch = "loongarch64"))] | |||
| #[inline] | |||
| pub fn fstat<Fd: AsFd>(fd: Fd) -> io::Result<Stat> { | |||
There was a problem hiding this comment.
I assume loongarch64 should support the public fstat API. There may be no __NR_fstat but if so then src/backend/linux_raw/fs/syscalls.rs' fstat can probably use statx instead.
| @@ -35,6 +36,7 @@ pub fn getrlimit(resource: Resource) -> Rlimit { | |||
| /// | |||
| /// [POSIX]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/setrlimit.html | |||
| /// [Linux]: https://man7.org/linux/man-pages/man2/setrlimit.2.html | |||
| #[cfg(not(target_arch = "loongarch64"))] | |||
| #[inline] | |||
| pub fn setrlimit(resource: Resource, new: Rlimit) -> io::Result<()> { | |||
There was a problem hiding this comment.
Similarly, I assume loongarch64 should support the public setrlimit API even if there is no __NR_setrlimit, as it can use prlimit64 instead.
No description provided.