-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[instantiation linking] Create and import WASMTableInstance #3898
Open
lum1n0us
wants to merge
33
commits into
bytecodealliance:dev/instantiate_linking
Choose a base branch
from
lum1n0us:feat/inst_linking_table
base: dev/instantiate_linking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[instantiation linking] Create and import WASMTableInstance #3898
lum1n0us
wants to merge
33
commits into
bytecodealliance:dev/instantiate_linking
from
lum1n0us:feat/inst_linking_table
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ~99% same with memory_instantiation() in wasm_runtime.c - new apis to create and destroy memory
…tantiation logic in wasm_runtime.c
The main goal is to let existed code run without modification
…ctor related import handling in thread management
… for imported tables
…nstantiate function
…es based on package version
…oved clarity and consistency
…destruction logic
…ed clarity and consistency; restore aot_compile_get_tbl_inst function
…ic for improved clarity
…tantiate function
lum1n0us
force-pushed
the
feat/inst_linking_table
branch
from
November 10, 2024 14:07
0e0841f
to
39c2cf1
Compare
lum1n0us
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
November 11, 2024 07:02
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.