Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[30.0.0] ci: generate a list of generated files #10270

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Feb 21, 2025

This is a backport of #10267: The fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by :, runs into issues with Windows absolute paths (e.g., C:\...). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation.

* ci: generate a list of generated files

This fix is necessary for Windows users who may be using absolute-path
target directories: the previous solution, separating the paths by `:`,
runs into issues with Windows absolute paths (e.g., `C:\...`). This
change is similar to bytecodealliance#10266 but should avoid any further OS
compatibility issues during a hypothetical cross-compilation.

prtest:full

* fix: debug string
@abrown abrown requested a review from a team as a code owner February 21, 2025 19:26
@abrown abrown requested review from cfallin and removed request for a team February 21, 2025 19:26
@alexcrichton
Copy link
Member

For CI I think you'll need to backport #10253 too

@abrown
Copy link
Contributor Author

abrown commented Feb 21, 2025

@alexcrichton, I have a commit changing the release notes; should that go in this PR or a separate one?

@alexcrichton
Copy link
Member

Adding here works fine yeah

CI is currently failing due to missing audits for the following Bytecode
Alliance authored crates:

* `wasmtime-wasi-io`
* `cranelift-assembler-x64`
* `cranelift-assembler-meta`
@abrown abrown requested a review from a team as a code owner February 21, 2025 19:45
@abrown abrown requested review from pchickey and removed request for a team February 21, 2025 19:45
@abrown abrown changed the title ci: generate a list of generated files [30.0.0] ci: generate a list of generated files Feb 21, 2025
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator wasmtime:docs Issues related to Wasmtime's documentation labels Feb 21, 2025
@abrown abrown merged commit 0b3cdd9 into bytecodealliance:release-30.0.0 Feb 21, 2025
154 checks passed
@abrown abrown deleted the backport-windows-fix branch February 21, 2025 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cranelift Issues related to the Cranelift code generator wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants