-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[30.0.0] ci: generate a list of generated files #10270
Merged
abrown
merged 5 commits into
bytecodealliance:release-30.0.0
from
abrown:backport-windows-fix
Feb 21, 2025
Merged
[30.0.0] ci: generate a list of generated files #10270
abrown
merged 5 commits into
bytecodealliance:release-30.0.0
from
abrown:backport-windows-fix
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: generate a list of generated files This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by `:`, runs into issues with Windows absolute paths (e.g., `C:\...`). This change is similar to bytecodealliance#10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation. prtest:full * fix: debug string
alexcrichton
approved these changes
Feb 21, 2025
cfallin
approved these changes
Feb 21, 2025
For CI I think you'll need to backport #10253 too |
@alexcrichton, I have a commit changing the release notes; should that go in this PR or a separate one? |
Adding here works fine yeah |
CI is currently failing due to missing audits for the following Bytecode Alliance authored crates: * `wasmtime-wasi-io` * `cranelift-assembler-x64` * `cranelift-assembler-meta`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cranelift
Issues related to the Cranelift code generator
wasmtime:docs
Issues related to Wasmtime's documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #10267: The fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by
:
, runs into issues with Windows absolute paths (e.g.,C:\...
). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation.