Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add wasi_http_double_echo test #7412

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Oct 30, 2023

This tests streaming outgoing request bodies, which we didn't previously have coverage for.

@dicej dicej requested a review from a team as a code owner October 30, 2023 20:06
@dicej dicej requested review from fitzgen and elliottt and removed request for a team and fitzgen October 30, 2023 20:06
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you Joel!

This tests streaming outgoing request bodies, which we didn't previously have
coverage for.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej dicej force-pushed the wasi-http-double-echo branch from 1782a16 to 0eb8d66 Compare October 31, 2023 17:17
@dicej dicej added this pull request to the merge queue Oct 31, 2023
Merged via the queue into bytecodealliance:main with commit 8aec021 Oct 31, 2023
18 checks passed
@dicej dicej deleted the wasi-http-double-echo branch October 31, 2023 20:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants