Wasmtime(gc): Support (ref.i31 (global.get $g)) const expressions
#8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
requested review from
abrown and
alexcrichton
and removed request for
a team
fitzgen
force-pushed
the
i31-global-initializers
branch
from
01dabb7 to
574f70a
Compare
github-actions
bot
added
cranelift
fitzgen
force-pushed
the
i31-global-initializers
branch
from
574f70a to
53d8268
Compare
There was a problem hiding this comment.
Looks good to me, I think the organization worked out well here.
My main comment is that the unsafe methods feel a little too unsafe and while I don't think there's a whole lot that can be done about that I still think it would be good to at least assert that Concrete heap types are functions for now to avoid accidental confusion in the future.
We had something hacked together to support `(ref.i31 (i32.const N))`. It wasn't a long-term solution. This is the first time that we have to really deal with multi-instruction const expressions. This commit introduces a tiny interpreter to evaluate const expressions.
fitzgen
force-pushed
the
i31-global-initializers
branch
from
53d8268 to
19c2b23
Compare
alexcrichton
approved these changes
Apr 24, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Aug 19, 2024
This commit builds on the support added in bytecodealliance#8450 to extend our simple interpreter with support for the `extended-const` proposal to WebAssembly. This is required when updating the spec-test-submodule since `extended-const` was merged into the mainline specification and some proposals are starting to rebase on that.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
This commit builds on the support added in #8450 to extend our simple interpreter with support for the `extended-const` proposal to WebAssembly. This is required when updating the spec-test-submodule since `extended-const` was merged into the mainline specification and some proposals are starting to rebase on that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had something hacked together to support
(ref.i31 (i32.const N)). It wasn't a long-term solution. This is the first time that we have to really deal with multi-instruction const expressions.This commit introduces a tiny interpreter to evaluate const expressions.