CI: Test Pulley on 32-bit and no_std targets
#9013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds CI testing for Pulley on the following 32-bit targets: * `i686-unknown-linux-gnu` * `armv7-unknown-linux-gnueabihf` The previous commit added checks that Pulley builds for `no_std` targets. Our existing test sharding means that it is already tested on a big-endian platform (`s390x-unknown-linux-gnu`) as well as on different OSes (Linux, Windows, and macOS). So altogether we are now testing a pretty wide range of portability dimensions for Pulley in CI: * 32- vs. 64-bit architectures * `std` vs. `no_std` * Little- vs. big-endian * Linux vs. Windows vs. macOS I think our CI coverage for Pulley is in a pretty good place now! Co-Authored-By: Alex Crichton <alex@alexcrichton.com>
alexcrichton
approved these changes
Jul 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CI testing for Pulley on the following 32-bit targets:
i686-unknown-linux-gnuarmv7-unknown-linux-gnueabihfIt also checks that Pulley builds for
no_stdtargets.Our existing test sharding means that it is already tested on a big-endian
platform (
s390x-unknown-linux-gnu) as well as on different OSes (Linux,Windows, and macOS).
So altogether we are now testing a pretty wide range of portability dimensions
for Pulley in CI:
stdvs.no_stdI think our CI coverage for Pulley is in a pretty good place now!