Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

wasi-sockets: Return StreamError::Closed when the underlying socket is shut down. #9055

Merged
merged 4 commits into from
Aug 1, 2024
Merged

wasi-sockets: Return StreamError::Closed when the underlying socket is shut down. #9055

merged 4 commits into from
Aug 1, 2024

Conversation

badeend
Copy link
Contributor

@badeend badeend commented Aug 1, 2024

And added a new LastWrite::Closed status to ensure that the OutputStream keeps closed.

Additional changes:

@badeend badeend requested a review from a team as a code owner August 1, 2024 14:50
@badeend badeend requested review from elliottt and removed request for a team August 1, 2024 14:50
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Aug 1, 2024
alexcrichton
alexcrichton approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Aug 1, 2024
Merged via the queue into bytecodealliance:main with commit cfc5035 Aug 1, 2024
38 checks passed
@badeend badeend mentioned this pull request Sep 12, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@elliottt elliottt Awaiting requested review from elliottt elliottt is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badeend @alexcrichton