Copy skeleton unit attributes for split DWARF #9151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skeleton unit may contain attributes that don't appear in the split unit. In particular, this includes DW_AT_ranges and DW_AT_comp_dir. Also, set the correct form for the default directory in the line program. Previously, the different form meant that we emitted the directory again when a file used it. Copying the DW_AT_comp_dir attribute is required for use of the default directory to work successfully.
alexcrichton
approved these changes
Aug 20, 2024
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skeleton unit may contain attributes that don't appear in the split unit. In particular, this includes DW_AT_ranges and DW_AT_comp_dir.
Also, set the correct form for the default directory in the line program. Previously, the different form meant that we emitted the directory again when a file used it. Copying the DW_AT_comp_dir attribute is required for use of the default directory to work successfully.