[DWARF] Synthetic type centralization #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
commented
Dec 1, 2024
| unit_id | ||
| } | ||
|
|
||
| fn create_vmctx_ptr_die( |
There was a problem hiding this comment.
Below code was simply moved from utils.rs without functional changes.
SingleAccretion
commented
Dec 1, 2024
Comment on lines
-348
to
+346
| let mut module_wasm_types = PrimaryMap::new(); | ||
| for (module, memory_offset) in compilation.module_memory_offsets.iter() { | ||
| let wasm_types = add_wasm_types(unit, root_id, out_strings, memory_offset); | ||
| let i = module_wasm_types.push(wasm_types); | ||
| assert_eq!(i, module); | ||
| } | ||
|
|
||
| let wasm_types = add_wasm_types(unit, root_id, out_strings); |
There was a problem hiding this comment.
Since all of the remaining wasm_types are module-invariant, there is no longer a need for them to be per-module.
SingleAccretion
changed the title
SingleAccretion
changed the title
SingleAccretion
requested review from
alexcrichton
and removed request for
a team
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DWARF transform needs to add some "synthetic" types to the output, mainly to represent the VMContext structure.
So far, these types were being added to each CU, which is unnecessary overhead since they're exactly the same in each CU in a given module.
This change moves them to a single per-module CU that is references via DWARF's
DW_FORM_ref_addrmechanism.This is an optimization in both time (the debugger needs fewer types to keep track of) and space (the
.debug_infosection is ~5% smaller on some DWARF input I have).