feat(wit-bindgen-go): align flags decoding #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when this is OK, I will squash the commits and update the commit message. |
rvolosatovs
reviewed
Jun 28, 2024
rvolosatovs
reviewed
Jun 28, 2024
rvolosatovs
reviewed
Jun 28, 2024
rvolosatovs
reviewed
Jun 28, 2024
|
btw, just a note here - I've just realized that WebAssembly/component-model#370 is a thing and the change was already merged in |
feel free to squash/rebase if you wish! |
Flags encoding/decoding in Go is now rewritten to use the correct binary encoding. Flag structs now contain an addition ReadFromIndex method that can be used for decoding. This makes the generated code more testable.
tchap
force-pushed
the
feature/wit-bindgen-go-flags
branch
from
e54cae7 to
9e8caeb
Compare
Done. |
rvolosatovs
approved these changes
Jun 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags are now encoded/decoded as bitmaps according to the binary encoding spec.
To decode flags,
ReadFromIndexis now being generated as a standalone method so that it can be tested.Basic tests added for both encoding and decoding.