Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use null instead of an object with undefined properties #51

Merged

Conversation

Elettrotecnica
Copy link

This will be coalesced to an empty object, which keeps the expected behavior. The previous default would trigger a warning in the console about it not being conform to the vec3 property type definition.

Warning is:

core:schema:warn Default value [object Object] does not match type vec3 in component ammo-body

This will be coalesced to an empty object, which keeps the expected behavior. The previous default would trigger a warning in the console about it not being conform to the vec3 property type definition.
@diarmidmackenzie
Copy link
Member

Thanks for this.

@diarmidmackenzie diarmidmackenzie merged commit 9963117 into c-frame:master Oct 12, 2023
4 of 6 checks passed
@Elettrotecnica Elettrotecnica deleted the fix-ammo-body-schema branch December 28, 2023 11:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants