-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update three-to-ammo dependency to new c-frame fork #60
Update three-to-ammo dependency to new c-frame fork #60
Conversation
package.json
Outdated
@@ -45,7 +45,7 @@ | |||
"ammo-debug-drawer": "^0.1.0", | |||
"cannon-es": "^0.9.1", | |||
"patch-package": "^6.5.0", | |||
"three-to-ammo": "^1.0.1", | |||
"@c-frame/three-to-ammo": "^1.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just published 1.0.2. Not sure what 1.0.3 is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - just seen c-frame/three-to-ammo#5 & now understand. I will merge & pubish that and then come back to this.
To get this to build, I had to update references in
Not sure whether that's the best fix, or if there's some way to alias three-to-ammo to @c-frame/three-to-ammo in package.json, which might be a more elegant solution? |
…quires in the code do not break
Sorry for not checking thoroughly, should be fine now, I have used an alias so that the logical dependency does not change |
Thanks for this. Do you need me to publish an update to npm? |
three-to-ammo 1.0.3 is the latest and it seems you have published it. I think we are all set! :-) Thanks a lot! |
Concerning this repo, personally I do not use this from cdn, but maybe a release wouldn't be bad. I could look into it if you prefer. |
See #59