Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change!: variable and constant tensors are now different types #6

Merged
merged 1 commit into from
May 26, 2022

Conversation

c0dearm
Copy link
Owner

@c0dearm c0dearm commented May 26, 2022

Constant and variable tensors are now different types, which means, after getting lost on many computations the developer can know which of the resulting tensors are still constants or variables. Another benefit from this is that code is clearer now, as we don't need to assert at runtime if a tensor is a constant, for example when deciding if computing a gradient or not.

Aside from this, I've also spent 10 minutes designing a logo for the library, given I have 0 skill for this I am quite happy with the result!

@codecov-commenter
Copy link

Codecov Report

Merging #6 (df8c10e) into main (bfd77ab) will decrease coverage by 2.28%.
The diff coverage is 69.66%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   74.12%   71.83%   -2.29%     
==========================================
  Files           7        7              
  Lines         286      245      -41     
==========================================
- Hits          212      176      -36     
+ Misses         74       69       -5     
Impacted Files Coverage Δ
src/context/storage.rs 25.00% <14.28%> (+15.00%) ⬆️
src/gradient.rs 29.41% <28.00%> (-48.37%) ⬇️
src/context/function.rs 50.00% <50.00%> (+3.70%) ⬆️
src/context/mod.rs 50.00% <60.00%> (-1.62%) ⬇️
src/tensor.rs 60.46% <60.46%> (-12.87%) ⬇️
src/context/tape.rs 88.88% <93.33%> (+7.07%) ⬆️
src/ops.rs 99.09% <98.87%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd77ab...df8c10e. Read the comment docs.

@c0dearm c0dearm merged commit 783d472 into main May 26, 2022
@c0dearm c0dearm deleted the 0.3.0 branch June 8, 2022 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants