Untrim timeline when zoomed #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major revert of functionaility. We decided that trimming while zoomed in was not worth the zoom accuracy bugs we kept hitting. Instead, we are disabling trimming when zoomed in. This means reverting a swath of patches. We still kept the logic that determines the zoom region based on the data points inside it. This logic is slightly changed to use the timeline time of the data points rather than the pixel position. This commit also includes the other improvements added during the zoom process: - Zoom extent covers the rulers - Last lane of timeline doesn't collide with edge if tracks disabled - y/m/d notation for ruler - Single click zooming
inodb
approved these changes
Apr 16, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This is a major revert of functionaility. We decided that trimming
while zoomed in was not worth the zoom accuracy bugs we kept hitting.
Instead, we are disabling trimming when zoomed in. This means
reverting a swath of patches.
We still kept the logic that determines the zoom region based on
the data points inside it. This logic is slightly changed to use
the timeline time of the data points rather than the pixel position.
This commit also includes the other improvements added during the zoom
process:
- Zoom extent covers the rulers
- Last lane of timeline doesn't collide with edge if tracks disabled
- y/m/d notation for ruler
- Single click zooming
@inodb