Update HistoryBuffers during client TickEvents #798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ResourceHistory and ComponentHistory to use the same HistoryBuffer under the hood. The HistoryBuffer doesn't use a heap anymore but a VecDeque. That's because the updates to the HistoryBuffer are pushed/removed in sequential order.
TODO: the same can be applied to InterpolationHistory since the replication updates are ordered on the receiver side)
Make sure that rollback for non-networked resource works correctly.
An issue was that the history was only updated once the client was synced. Therefore we would get in a situation where:
X-Rollback
, which triggers a rollbackX-Rollback
, so the resource gets removed.My fix is: