-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bring cSploit code up to date (Android Pie/AS 3.3 current) + AndroidX + other fixes #968
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This was an issue in ACRA. Thanks to vczilla & gregd for chasing it down. See issue cSploit#941
(@xaitax heads up if you can do a test build it would be appreciated.) |
No problem. Once you commit it will be automatically built. |
@fat-tire It's just sad this project isn't active.. cause it's a hell of an app (or was). |
@kimocoder Cool If you build it without issue and it looks like it works I'll accept the changes to the devel branch and I guess the nightly builds will include it... Thx. |
I will build it once it's committed for everyone to test. ;) |
Q: Are you using AS 3.3 latest alpha/canary + latest gradle test? |
Yes. AS 3.3 Canary 6 |
Hmm.... From this it appears a solution may be to add to
Strangely I don't need it. But tell me if it fixes anything and if so I'll add it. Update: Actually the issue is with the AndroidX version not being available rather than the old multidex.... Is it possible you haven't updated your library support in Android Studio to the latest? |
I'm running on a clean AS 3.3 Canary 6. Do I need any packages installed? If yes, well.. which to be specific? |
I've just updated this to include multidex. You should use the latest canary 7 I think. In the SDK Manager, you want to have the latest build tools and libraries and stuff up to date Can you try building this latest version and let me know if it builds for you? |
Hmm it shouldn't be using v4.app.anything now that it's using jetpack, which replaced the support library stuff. Can you try clearing the app's cache (it's in one of the menus) and the build files and restarting AS completely, and if that doesn't work take a look at this as something there may help? it's strange because using AS canary, I don't have this (or the other multidex issue)... |
As a (simpler) alternative solution, what happens if you remove mavencentral() completely in all four places, ie:
When I try it it builds fine. If you can report it works, I'll push it and then merge to |
That's so strange. So the solution for you is to add that maven url line? Putting that back lets it build? |
Wow.. really don't know whats happening over here. Tried to replay the build from yesterday, which was successfull.. but noe I only get the above issue with the exact same maven url lines I used yesterday. Better you do this without me, it may be my low experience on AS that's causing the troubles, but this is a bit weird anyways |
Alrighty, thanks @kimocoder for giving it a shot-- as it's been a few days and it #worksforme I'll commit to |
Can't build unfortunately. Downloaded a fresh SDK and installed:
Anything missing? |
Task :cSploit:transformClassesWithMultidexlistForRelease FAILED FAILURE: Build failed with an exception.
|
It's kind of hard to tell from that list as it's missing C/Rs but here is my installed list... . When I do ./gradlew assembleRelease it builds for a while and ends with BUILD SUCCESSFUL in 57s... Can you build a debug build? Also, could you paste the build log somewhere? You have updated the SDK? |
You have basically everything installed, huh? ;) I posted the assembleDebug Log here: https://paste2.org/GKdMVCVw SDK is latest from today - got a fresh one and then installed the above shown packages. In the meantime I will go through your list and see what might make sense to install as well. |
From my point of view, there is something with the "support library" that's off |
Hmm. A few observations:
The support library is completely switched from the old style to the androidx jetpack stuff. Dunno if anything special needs to be downloaded to support that. Per this, can you try with --stacktrace to get more detail? The only errors I see are some translated strings that don't appear in the default string xml. |
(also-- yeah i pretty much include everything. Or rather, over time they've all eventually been installed...) |
Yeah, building it with JDK 1.8. Output with stacktrace here: |
Do you guys have the following in
If not please add these two lines to Thx! |
There is lots of information of the build issue around the Google, just don't have time to look into it for a week or so.. |
Yeah I think adding those lines to gradle.properties will fix this. @xaitax can you confirm? |
It built. Can you try the nightly please? Also please not only run it but also test if some of the tools still work. Do not have a rooted phone here. |
I got the Nexus 6P and I may confirm there are several issue.. May disclose them after work this evening |
Awesome @xaitax! @kimocoder please do post any issues you find. I am probably going to update the gradle dist (4.10 is out now) as well as add those two lines to gradle.properties in the next day or so... though feel free to do so if I don't get to it soon. |
Done! #969 |
@fat-tire there is an issue running this.. at startup, this happens before force closing Android v7.1.1 |
Nevermind, got it working by using the nightly build instead |
Nice to see @fat-tire keeping us alive :D |
Just brought the build up to date and tested on an older Android 6.01 device, which seems to still work. That's not to say there aren't going to be problems-- but my cursory tests didn't find them. Was able to do a portscan and MITM of a test rasppi on the local network, and that's about all I tested. Themes and stuff still works on the device I tested, and the appcompat/androidx support should be more complete.
This should hopefully fix the #941 permissions issue as well, though someone else will have to confirm this on newer Android.
If no one has any complaints, I'll probably just accept this commit in a few days or so into the
develop
branch.. If you do have complaints, please submit a proposed solution if possible.Cheers!