feat: mapping slice of complex struct #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 429 498 +69
=========================================
+ Hits 429 498 +69 ☔ View full report in Codecov by Sentry. |
|
/cc @caarlos0 PTAL, thanks |
|
Hi @caarlos0, could you please review this PR when you have a moment? I am happy to make any changes if needed. Thank you! |
caarlos0
approved these changes
Jul 1, 2024
|
Hey, Happy to hear that |
added 2 commits
July 15, 2024 23:16
# Conflicts: # env_test.go
|
Dear @caarlos0, I added a sample to the readme. Please check it up when you can |
caarlos0
approved these changes
Jul 18, 2024
|
many thanks, this looks great! |
BorzdeG
pushed a commit
to BorzdeG/env
that referenced
this pull request
Aug 24, 2024
* feat: mapping slice of complex struct caarlos0#298 * feat: support predefined values and pre initialized structs * refactor: some improvement * refactor: some improvement * test: support normal features for nested fields * test: trying to fix `gofumpt` lint issues * chore: add sample for complex struct in readme --------- Co-authored-by: Hamid Reza Ranjbar <hamidreza.ranjbar@snapp.cab>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: mapping slice of complex struct. #298