network blocking

[ghost]

This patch uses the swarm opts.verify hook and cabal.removeConnection() to implement network-level blocking of peers. This is only part of what we'll need for a full implementation of blocking since you can still get the content from blocked peers via other peers. I also had to make some room in the command-handling to support blocks as well as other arbitrary flags. Before these changes any flags that weren't hide/unhide wouldn't show up correctly.

depends on cabal-club/cabal-core#96

[cblgh]

this is really dope :3

looks like it is missing logic to show messages on clients when e.g. someone i trust (mod/admin) has blocked someone, see the existing logic for (un)hide/mod/admin

cabal-client/src/cabal-details.js

Lines 717 to 764 in ee626cd

	// there was no change in behaviour, e.g. someone modded an already
	// modded person, hid someone that was already hidden
	const changeOccurred = Object.keys(changedRole).filter(r => changedRole[r]).length > 0
	if (!changeOccurred) {
	this._emitUpdate('user-updated', { key: info.id, user })
	if ((user.flags.get('@') || []).includes('block')) {
	// drop the connection to blocked users immediately
	this.core.removeConnection(info.id)
	}
	return
	}
	const type = doc.type.replace(/^flags\//, '')
	let action, text
	if (['admin', 'mod'].includes(role)) { action = (type === 'add' ? 'added' : 'removed') }
	if (role === 'hide') { action = (type === 'add' ? 'hid' : 'unhid') }
	if (role === 'hide') {
	text = `${issuerName} ${action} ${user.name} ${reason}`
	} else {
	text = `${issuerName} ${action} ${user.name} as ${role} ${reason}`
	}
	const obj = { issuer: info.by, receiver: info.id, role, type, reason }
	this._emitUpdate('user-updated', { key: info.id, user })
	const msg = {
	key: '!status',
	value: {
	timestamp: timestamp(),
	type: 'chat/moderation',
	content: {
	text,
	issuerid: info.by,
	receiverid: info.id,
	role,
	type,
	reason
	}
	}
	}
	// add to !status channel, to have a canonical log of all moderation actions in one place
	this.addStatusMessage(msg, '!status')
	// also add to the currently focused channel, so that the moderation action isn't missed
	if (this.chname !== '!status') {
	this.addStatusMessage(msg)
	}
	})
	})

[garbados]

Woo! Network-level blocking!

Does this also undownload the blocked peer's feed? Such as in the case of an illegal number attack, spamming, etc.

[ghost]

This patch doesn't yet delete the remote feed and refuse to replicate it again. That is the second part of implementing this feature fully which will require some changes upstream in multifeed.

[garbados]

Noted, thanks 👍