Skip to content

Advanced Component Group Ordering #212

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

use Cachet\Enums\ResourceOrderColumnEnum;
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::table('component_groups', function (Blueprint $table) {
$table->string('order_column')->nullable()->after('order');
$table->char('order_direction', 4)->nullable()->after('order_column');
});

DB::table('component_groups')->update(['order_column' => ResourceOrderColumnEnum::Manual->value]);
}

/**
* Reverse the migrations.
*/
public function down(): void
{
Schema::table('component_groups', function (Blueprint $table) {
$table->dropColumn([
'order_column',
'order_direction',
]);
});
}
};
3 changes: 3 additions & 0 deletions resources/lang/en/component_group.php
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
'name' => 'Name',
'visible' => 'Visible',
'collapsed' => 'Collapsed',
'order_column' => 'Component Group Order',
'created_at' => 'Created at',
'updated_at' => 'Updated at',
],
@@ -25,5 +26,7 @@
'name_label' => 'Name',
'visible_label' => 'Visible',
'collapsed_label' => 'Collapsed',
'order_column_label' => 'Component Group Order',
'order_direction' => 'Order Direction',
],
];
11 changes: 11 additions & 0 deletions resources/lang/en/resource.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
<?php

return [
'order_column' => [
'id' => 'ID',
'last_updated' => 'Last Updated',
'name' => 'Name',
'manual' => 'Manual',
'status' => 'Status',
],
'order_direction' => [
'asc' => 'Ascending',
'desc' => 'Descending',
],
'visibility' => [
'authenticated' => 'Users',
'guest' => 'Guests',
7 changes: 7 additions & 0 deletions resources/views/components/component-groups.blade.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
@foreach($componentGroups as $componentGroup)
<x-cachet::component-group :component-group="$componentGroup"/>
@endforeach

@foreach($ungroupedComponents as $component)
<x-cachet::component-ungrouped :component="$component" />
@endforeach
9 changes: 2 additions & 7 deletions resources/views/status-page/index.blade.php
Original file line number Diff line number Diff line change
@@ -5,14 +5,9 @@
<x-cachet::status-bar />

<x-cachet::about />
@foreach ($componentGroups as $componentGroup)
<x-cachet::component-group :component-group="$componentGroup" />
@endforeach

@foreach ($ungroupedComponents as $component)
<x-cachet::component-ungrouped :component="$component" />
@endforeach

<x-cachet::component-groups />

<x-cachet::metrics />

@if ($schedules->isNotEmpty())
38 changes: 38 additions & 0 deletions src/Enums/ResourceOrderColumnEnum.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php

namespace Cachet\Enums;

use Filament\Support\Contracts\HasLabel;

enum ResourceOrderColumnEnum: string implements HasLabel
{
case Id = 'id';
case LastUpdated = 'last_updated';
case Name = 'name';
case Manual = 'manual';
case Status = 'status';

public function getLabel(): string
{
return match ($this) {
self::Id => __('cachet::resource.order_column.id'),
self::LastUpdated => __('cachet::resource.order_column.last_updated'),
self::Name => __('cachet::resource.order_column.name'),
self::Manual => __('cachet::resource.order_column.manual'),
self::Status => __('cachet::resource.order_column.status'),
};
}

/**
* Determine if the column requires a direction.
*/
public static function requiresDirection(): array
{
return [
self::Id,
self::LastUpdated,
self::Name,
self::Status,
];
}
}
29 changes: 29 additions & 0 deletions src/Enums/ResourceOrderDirectionEnum.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

namespace Cachet\Enums;

use Filament\Support\Contracts\HasLabel;

enum ResourceOrderDirectionEnum: string implements HasLabel
{
case Asc = 'asc';
case Desc = 'desc';

public function getLabel(): string
{
return match ($this) {
self::Asc => __('cachet::resource.order_direction.asc'),
self::Desc => __('cachet::resource.order_direction.desc'),
};
}

public function ascending(): bool
{
return $this === self::Asc;
}

public function descending(): bool
{
return $this === self::Desc;
}
}
25 changes: 24 additions & 1 deletion src/Filament/Resources/ComponentGroupResource.php
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@
namespace Cachet\Filament\Resources;

use Cachet\Enums\ComponentGroupVisibilityEnum;
use Cachet\Enums\ResourceOrderColumnEnum;
use Cachet\Enums\ResourceOrderDirectionEnum;
use Cachet\Enums\ResourceVisibilityEnum;
use Cachet\Filament\Resources\ComponentGroupResource\Pages;
use Cachet\Filament\Resources\ComponentResource\RelationManagers\ComponentsRelationManager;
@@ -42,9 +44,21 @@ public static function form(Form $form): Form
->required()
->inline()
->options(ComponentGroupVisibilityEnum::class)
->default(ComponentGroupVisibilityEnum::expanded)
->default(ComponentGroupVisibilityEnum::expanded->value)
->columnSpanFull(),
]),
Forms\Components\Section::make()->schema([
Forms\Components\Select::make('order_column')
->label(__('cachet::component_group.form.order_column_label'))
->options(ResourceOrderColumnEnum::class)
->required()
->reactive(),
Forms\Components\Select::make('order_direction')
->label(__('cachet::component_group.form.order_direction'))
->options(ResourceOrderDirectionEnum::class)
->required(fn (Forms\Get $get) => $get('order_column') !== ResourceOrderColumnEnum::Manual->value)
->visible(fn (Forms\Get $get) => $get('order_column') !== ResourceOrderColumnEnum::Manual->value),
])
]);
}

@@ -63,6 +77,15 @@ public static function table(Table $table): Table
Tables\Columns\TextColumn::make('collapsed')
->label(__('cachet::component_group.list.headers.collapsed'))
->sortable(),
Tables\Columns\TextColumn::make('order_column')
->icon(fn ($record) => match (true) {
$record->order_column === ResourceOrderColumnEnum::Manual => 'heroicon-o-chevron-up-down',
$record->order_direction === ResourceOrderDirectionEnum::Asc => 'heroicon-o-arrow-up',
$record->order_direction === ResourceOrderDirectionEnum::Desc => 'heroicon-o-arrow-down',
default => null,
})
->label(__('cachet::component_group.list.headers.order_column'))
->sortable(),
Tables\Columns\TextColumn::make('created_at')
->label(__('cachet::component_group.list.headers.created_at'))
->dateTime()
16 changes: 3 additions & 13 deletions src/Http/Controllers/StatusPage/StatusPageController.php
Original file line number Diff line number Diff line change
@@ -2,11 +2,14 @@

namespace Cachet\Http\Controllers\StatusPage;

use Cachet\Enums\ResourceOrderColumnEnum;
use Cachet\Models\Component;
use Cachet\Models\ComponentGroup;
use Cachet\Models\Incident;
use Cachet\Models\Schedule;
use Filament\Resources\Resource;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Facades\DB;
use Illuminate\View\View;

class StatusPageController
@@ -17,19 +20,6 @@ class StatusPageController
public function index(): View
{
return view('cachet::status-page.index', [
'componentGroups' => ComponentGroup::query()
->with(['components' => fn ($query) => $query->enabled()->orderBy('order')->withCount('incidents')])
->visible(auth()->check())
->orderBy('order')
->when(auth()->check(), fn (Builder $query) => $query->users(), fn ($query) => $query->guests())
->get(),
'ungroupedComponents' => Component::query()
->enabled()
->whereNull('component_group_id')
->orderBy('order')
->withCount('incidents')
->get(),

'schedules' => Schedule::query()->with('updates')->incomplete()->orderBy('scheduled_at')->get(),
]);
}
15 changes: 15 additions & 0 deletions src/Models/Component.php
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@

use Cachet\Database\Factories\ComponentFactory;
use Cachet\Enums\ComponentStatusEnum;
use Cachet\Enums\ResourceOrderColumnEnum;
use Cachet\Events\Components\ComponentCreated;
use Cachet\Events\Components\ComponentDeleted;
use Cachet\Events\Components\ComponentUpdated;
@@ -138,6 +139,20 @@ public function latestStatus(): Attribute
return Attribute::get(fn () => $this->incidents()->unresolved()->latest()->first()?->pivot->component_status ?? $this->status);
}

/**
* Determine how to order the component.
*/
public function orderableBy(ComponentGroup $group): mixed
{
return match ($group->order_column) {
ResourceOrderColumnEnum::Id => $this->id,
ResourceOrderColumnEnum::LastUpdated => $this->updated_at,
ResourceOrderColumnEnum::Name => $this->name,
ResourceOrderColumnEnum::Manual => $this->order,
default => $this->status->value,
};
}

/**
* Create a new factory instance for the model.
*/
9 changes: 7 additions & 2 deletions src/Models/ComponentGroup.php
Original file line number Diff line number Diff line change
@@ -5,6 +5,8 @@
use Cachet\Concerns\HasVisibility;
use Cachet\Database\Factories\ComponentGroupFactory;
use Cachet\Enums\ComponentGroupVisibilityEnum;
use Cachet\Enums\ResourceOrderColumnEnum;
use Cachet\Enums\ResourceOrderDirectionEnum;
use Cachet\Enums\ResourceVisibilityEnum;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Factories\Factory;
@@ -34,7 +36,8 @@ class ComponentGroup extends Model

/** @var array<string, string> */
protected $casts = [
'order' => 'int',
'order_column' => ResourceOrderColumnEnum::class,
'order_direction' => ResourceOrderDirectionEnum::class,
'collapsed' => ComponentGroupVisibilityEnum::class,
'visible' => ResourceVisibilityEnum::class,
];
@@ -43,6 +46,8 @@ class ComponentGroup extends Model
protected $fillable = [
'name',
'order',
'order_column',
'order_direction',
'collapsed',
'visible',
];
@@ -54,7 +59,7 @@ class ComponentGroup extends Model
*/
public function components(): HasMany
{
return $this->hasMany(Component::class);
return $this->hasMany(Component::class)->chaperone('group');
}

public function isCollapsible(): bool
2 changes: 1 addition & 1 deletion src/Models/Incident.php
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ public function components(): BelongsToMany
*/
public function incidentComponents(): HasMany
{
return $this->hasMany(IncidentComponent::class);
return $this->hasMany(IncidentComponent::class)->chaperone();
}

/**
47 changes: 47 additions & 0 deletions src/View/Components/ComponentGroups.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Cachet\View\Components;

use Cachet\Models\ComponentGroup;
use Closure;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Collection;
use Illuminate\View\Component as ViewComponent;
use Illuminate\View\View;

class ComponentGroups extends ViewComponent
{
public function render(): View|Closure|string
{
return view('cachet::components.component-groups', [
'componentGroups' => $this->componentGroups(),
'ungroupedComponents' => \Cachet\Models\Component::query()
->enabled()
->whereNull('component_group_id')
->orderBy('order')
->withCount('incidents')
->get(),
]);
}

/**
* Fetch component groups with their components in the configured order.
*/
private function componentGroups(): Collection
{
return ComponentGroup::query()
->with(['components' => fn ($query) => $query->enabled()->orderBy('order')->withCount('incidents')])
->visible(auth()->check())
->when(auth()->check(), fn (Builder $query) => $query->users(), fn ($query) => $query->guests())
->get()
->map(function (ComponentGroup $group) {
$group->components = $group->components
->sortBy(
fn (\Cachet\Models\Component $component) => $component->orderableBy($group),
descending: $group->order_direction?->descending()
);

return $group;
});
}
}