Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add error handling for unrecognized subdirective/options #6884

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Add error handling for unrecognized subdirective/options #6884

merged 2 commits into from
Mar 8, 2025
+13 −0

Conversation

steffenbusch
Copy link
Contributor

Fixes #6863

mohammed90
mohammed90 approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I played with the exhaustive linter config in golangci-lint, and it apparently cannot catch these cases. It can only identify them when the switch is over enums. Sigh.

Thanks for helping with this!

@mohammed90 mohammed90 merged commit f4432a3 into caddyserver:master Mar 8, 2025
20 checks passed
@steffenbusch steffenbusch deleted the unrecognized-directives branch March 8, 2025 21:12
@mholt
Copy link
Member

mholt commented Mar 8, 2025

Yep this is good, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject unrecognized directives
3 participants
@steffenbusch @mholt @mohammed90