Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for implicit bootstrapping of modules #17

Closed
ecampidoglio opened this issue Sep 23, 2020 · 5 comments
Closed

Add support for implicit bootstrapping of modules #17

ecampidoglio opened this issue Sep 23, 2020 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@ecampidoglio
Copy link
Member

As of cake-build/cake#2849, modules are automatically bootstrapped before running the script. While it's still possible to do it explicitly with the --bootstrap option, it's no longer necessary. Instead, a new option has been introduced to opt out of the bootstrapping process called --skip-bootstrap.

The Cake action should reflect these changes both in the code and in the documentation.

@ecampidoglio ecampidoglio added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 23, 2020
@ecampidoglio ecampidoglio added this to the 1.3.0 milestone Oct 30, 2020
@ecampidoglio ecampidoglio modified the milestones: 1.3.0, 1.4.0 Jan 8, 2021
@nils-a
Copy link
Member

nils-a commented Sep 23, 2021

@ecampidoglio what if I chose to set cake-version to 0.38.5? I would need the "old" --bootstrap option. Would it be possible to change the cake-bootstrap setting to accept

  • bootstrap (equivalent to true for compatibility) to pass --bootstrap and
  • skip to pass --skip-bootstrap.

The documentation for this, then, should state that setting cake-bootstrap: bootstrap is only valid for Cake versions < 1.0.0 and, in turn, setting cake-bootstrap: skip is only valid for Cake versions >= 1.0.0.

@devlead
Copy link
Member

devlead commented Oct 31, 2022

0.* going out of support in a week or so, perhaps that concern can be skipped?

@ecampidoglio ecampidoglio removed this from the 1.4.0 milestone Nov 18, 2022
@ecampidoglio
Copy link
Member Author

I think you should be able to run any version of Cake via the action (that's what the cake-version parameter is for). This means supporting older versions.

Since we're releasing version 2.0.0 to address #41, we might as well take the opportunity to introduce other breaking changes.

How about we change the cake-bootstrap parameter from a boolean to a three-state switch:

cake-bootstrap: auto # The current default behavior
cake-bootstrap: explicit # Passes the --bootstrap option for Cake >= 1.0.0
cake-bootstrap: skip # Passes the --skip-bootstrap option for Cake <= 1.0.0

The action could detect the version of Cake being run and ignore the parameter if its current value isn't supported.

@ecampidoglio ecampidoglio self-assigned this Nov 18, 2022
@ecampidoglio ecampidoglio added this to the 2.0.0 milestone Nov 18, 2022
@devlead
Copy link
Member

devlead commented Nov 18, 2022

Sure, that sounds reasonable.

ecampidoglio added a commit that referenced this issue Nov 29, 2022
This commit changes the `cake-bootstrap` input from a boolean into a three-state switch.

The possible values are:

- auto: modules are automatically bootstrapped upon running the script (Cake >= 1.0.0)
- explicit: bootstraps the modules by passing the `--bootstrap` switch before running the script (Cake <= 1.0.0)
- skip: modules are not bootstrapped by passing the `--skip-bootstrap` switch when running the script (Cake >= 1.0.0)

The default value is `auto`.
ecampidoglio added a commit that referenced this issue Nov 30, 2022
This commit changes the `cake-bootstrap` input from a boolean into a three-state switch.

The possible values are:

- auto: modules are automatically bootstrapped upon running the script (Cake >= 1.0.0)
- explicit: bootstraps the modules by passing the `--bootstrap` switch before running the script (Cake <= 1.0.0)
- skip: modules are not bootstrapped by passing the `--skip-bootstrap` switch when running the script (Cake >= 1.0.0)

The default value is `auto`.
ecampidoglio added a commit that referenced this issue Dec 1, 2022
This commit changes the `cake-bootstrap` input from a boolean into a three-state switch.

The possible values are:

- auto: modules are automatically bootstrapped upon running the script (Cake >= 1.0.0)
- explicit: bootstraps the modules by passing the `--bootstrap` switch before running the script (Cake <= 1.0.0)
- skip: modules are not bootstrapped by passing the `--skip-bootstrap` switch when running the script (Cake >= 1.0.0)

The default value is `auto`.
ecampidoglio added a commit that referenced this issue Feb 5, 2023
This commit changes the `cake-bootstrap` input from a boolean into a three-state switch.

The possible values are:

- auto: modules are automatically bootstrapped upon running the script (Cake >= 1.0.0)
- explicit: bootstraps the modules by passing the `--bootstrap` switch before running the script (Cake <= 1.0.0)
- skip: modules are not bootstrapped by passing the `--skip-bootstrap` switch when running the script (Cake >= 1.0.0)

The default value is `auto`.
ecampidoglio added a commit that referenced this issue Feb 5, 2023
This commit changes the `cake-bootstrap` input from a boolean into a three-state switch.

The possible values are:

- auto: modules are automatically bootstrapped upon running the script (Cake >= 1.0.0)
- explicit: bootstraps the modules by passing the `--bootstrap` switch before running the script (Cake < 1.0.0)
- skip: modules are not bootstrapped by passing the `--skip-bootstrap` switch when running the script (Cake >= 1.0.0)

The default value is `auto`.
@ecampidoglio
Copy link
Member Author

Resolved by 3dc8398.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants