Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update the action to use Node20 #54

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Update the action to use Node20 #54

merged 2 commits into from
Apr 15, 2024

Conversation

baynezy
Copy link
Contributor

@baynezy baynezy commented Apr 5, 2024

Closes #52

@baynezy
Copy link
Contributor Author

baynezy commented Apr 5, 2024

@microsoft-github-policy-service agree

@baynezy
Copy link
Contributor Author

baynezy commented Apr 12, 2024

All the workflows pass on my fork. Do you need anything else to complete this PR?

@ecampidoglio ecampidoglio self-assigned this Apr 15, 2024
@ecampidoglio ecampidoglio added the dependencies Pull requests that update a dependency file label Apr 15, 2024
@ecampidoglio ecampidoglio added this to the 3.0.0 milestone Apr 15, 2024
ecampidoglio
ecampidoglio approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ecampidoglio ecampidoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ecampidoglio ecampidoglio merged commit 4a10f3b into cake-build:master Apr 15, 2024
6 checks passed
@ecampidoglio
Copy link
Member

Thank you for your contribution. This PR has been merged into master. However, given that upgrading to Node.js v20 is a breaking change, it will be released as part of the next major version.

In the meantime, you can reference the master branch in your workflows:

steps:
  - name: Run the Cake script
    uses: cake-build/cake-action@master

@baynezy
Copy link
Contributor Author

baynezy commented Apr 18, 2024

Thanks, @ecampidoglio - do you have a ballpark timeframe for the next release? I completely appreciate that this is a FOSS project and I have no expectations.

@ecampidoglio ecampidoglio removed this from the 3.0.0 milestone Apr 26, 2024
@eoehen eoehen mentioned this pull request Apr 26, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ecampidoglio ecampidoglio ecampidoglio approved these changes

Assignees

@ecampidoglio ecampidoglio

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Node20
2 participants
@baynezy @ecampidoglio