GH2228: Fix CakeTaskExtensions accessibility #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The TeamCity build failed with an unrelated error run |
gitfool
commented
Aug 16, 2018
| throw new ArgumentNullException(nameof(criteria)); | ||
| } | ||
| task.Criterias.Add(new CakeTaskCriteria(criteria, message)); | ||
| task.Criterias.Add(new CakeTaskCriteria(predicate, message)); |
There was a problem hiding this comment.
Note:
- I renamed the parameter from
criteriatopredicateto match the parameter name in theCakeTaskCriteriactor - I removed the check for null here because the
CakeTaskCriteriactor already does that
patriksvensson
approved these changes
Aug 16, 2018
devlead
approved these changes
Aug 16, 2018
|
@gitfool your changes have been merged, thanks for your contribution 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2228