-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
GH4278: Update Spectre.Console to 0.49.1 #4279
Conversation
devlead
commented
Nov 24, 2023
- fixes Update Spectre.Console to 0.49.1 #4278
It would seem Spectre.Console 0.48.0 has a breaking change with settings like cake/src/Cake/Commands/DefaultCommandSettings.cs Lines 55 to 57 in ed61202
This test fails cake/src/Cake.Tests/Unit/ProgramTests.cs Lines 101 to 104 in ed61202
only the last not investigated the root cause fully. |
Found the issue Spectre.Console.Cli no longer allows default commands to have a Will see if I can find away around that, can't use the default Spectre version command as it will produce a version string that will break Cake cli contract. Overriding command settings |
As it's by design breaking change in Spectre.Console.Cli, I just added a workaround to opt-out of this behavior for Cake.Tool. |
4176841
to
c173849
Compare
The breaking |
Ah would seem remaining arguments has changed in Specre.Console.Cli will investigate, PR still WIP. |
bf54e67
to
5385010
Compare
5385010
to
fec1acf
Compare
@cake-build/cake-team this should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍