Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Cake.SqlServer #152

Merged
merged 2 commits into from
Sep 13, 2016
Merged

Added Cake.SqlServer #152

merged 2 commits into from
Sep 13, 2016

Conversation

trailmax
Copy link
Contributor

@trailmax trailmax commented Sep 8, 2016

Added a description of the new SqlServer package into list of addins

@dnfclas
Copy link

dnfclas commented Sep 8, 2016

Hi @trailmax, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@gep13
Copy link
Member

gep13 commented Sep 10, 2016

@trailmax can I get you to do something for me?

As this PR stands right now, the generated documentation looks like this:

image

Which is missing all the documentation that you put into the source code here:

image

This is due to the fact that you are not including the XML Documentation file within in the NuGet Package. Would you be in a position to add this file into the NuGet Package, so that the documentation can be generated?

@gep13
Copy link
Member

gep13 commented Sep 10, 2016

Raised an issue about this here: cake-contrib/Cake.SqlServer#3

@trailmax
Copy link
Contributor Author

Added the missing xml file into nuget and added the reference to this file in the addins.xml.

@gep13 gep13 merged commit 945b1a8 into cake-build:develop Sep 13, 2016
@gep13
Copy link
Member

gep13 commented Sep 14, 2016

@trailmax thanks for getting this added. This is now live here: http://cakebuild.net/dsl/sqlserver

This was referenced Oct 19, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants