Set BaselineState when no existing issues are passed but BaselineGuid…

… is set
cake-contrib · Jun 24, 2024 · 80bda6f · 80bda6f
1 parent 6476749
commit 80bda6f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/Cake.Issues.Reporting.Sarif.Tests/SarifIssueReportGeneratorTests.cs b/src/Cake.Issues.Reporting.Sarif.Tests/SarifIssueReportGeneratorTests.cs
@@ -1078,4 +1078,31 @@ public void Should_Generate_Report_With_BaseLineState_None_If_BaselineGuid_Is_No
             result.BaselineState.ShouldBe(BaselineState.None);
         }
     }
+
+    [Fact]
+    public void Should_Generate_Report_With_BaseLineState_New_If_No_Existing_Issues()
+    {
+        // Given
+        var fixture = new SarifIssueReportFixture();
+        fixture.SarifIssueReportFormatSettings.BaselineGuid = Guid.NewGuid();
+
+        var issues =
+            new List<IIssue>
+            {
+                    IssueBuilder
+                        .NewIssue("Message Foo 1.", "ProviderType Foo", "ProviderName Foo")
+                        .Create(),
+
+            };
+
+        // When
+        var logContents = fixture.CreateReport(issues);
+
+        // Then
+        var sarifLog = JsonConvert.DeserializeObject<SarifLog>(logContents);
+
+        var run = sarifLog.Runs.ShouldHaveSingleItem();
+        var result = run.Results.ShouldHaveSingleItem();
+        result.BaselineState.ShouldBe(BaselineState.New);
+    }
 }
diff --git a/src/Cake.Issues.Reporting.Sarif/SarifIssueReportGenerator.cs b/src/Cake.Issues.Reporting.Sarif/SarifIssueReportGenerator.cs
@@ -49,8 +49,7 @@ protected override FilePath InternalCreateReport(IEnumerable<IIssue> issues)
 
         List<SarifIssue> sarifIssues = [];
 
-        if (this.sarifIssueReportFormatSettings.BaselineGuid != Guid.Empty &&
-            this.sarifIssueReportFormatSettings.ExistingIssues.Count > 0)
+        if (this.sarifIssueReportFormatSettings.BaselineGuid != Guid.Empty)
         {
             var issueComparerOnlyPersistentProperties = new IIssueComparer(true);
             var issueComparerAllProperties = new IIssueComparer(false);