Port to core #19
Port to core #19
Conversation
|
Thank you for your effort. But you have renamed the folder for the project from And build if run
Also am I right in saying that bacpac functionality is not going to work on .NetStandard? Any reason for that? |
|
Sorry for the rename, slight overview on my end. And for the bacpac functionality, the code is using the dependency "Microsoft.SqlServer.DacFx.x64" : "130.3485.1" does not have a net standard build to use. So in code we look at which framework we are using. There is still more work to be done with getting built too. I will be coming back to later on this week. |
| <file src="Microsoft.*.dll" target="lib/net45"/> | ||
| <file src="LICENSE" /> | ||
| </files> | ||
| <?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Line endings changed? white-space? files look identical, yet diff shows 100% change
| [assembly: AssemblyInformationalVersion("1.5.1-backpac.1+13.Branch.backpac.Sha.ea1d7b9246a302adb0f73eb9f55a8375480a503c")] | ||
| [assembly: AssemblyCopyright("Copyright (c) 2016 - 2016 AMV Software")] | ||
|
|
||
| //------------------------------------------------------------------------------ |
There was a problem hiding this comment.
Same as above. White-space?
| @@ -414,6 +414,7 @@ public static void RestoreSqlBackup(this ICakeContext context, String connection | |||
| /// }); | |||
| /// </code> | |||
| /// </example> | |||
| #if NET451 | |||
There was a problem hiding this comment.
#if NET451 should be above the XML comment, otherwise VS goes crazy
| @@ -451,7 +452,8 @@ public static void CreateBacpacFile(this ICakeContext context, String connection | |||
| /// }); | |||
| /// }); | |||
| /// </code> | |||
| /// </example> | |||
| /// </example> | |||
| #if NET451 | |||
There was a problem hiding this comment.
Same as above - #if should include xml-comment
| @@ -156,6 +156,7 @@ internal static SqlConnection OpenSqlConnection(ICakeContext context, String con | |||
| } | |||
| catch (SqlException exception) | |||
| { | |||
| #if Net541 | |||
| @@ -164,6 +165,16 @@ internal static SqlConnection OpenSqlConnection(ICakeContext context, String con | |||
| var newException = new Exception(errorMessage, exception); | |||
| throw newException; | |||
| } | |||
| #else | |||
There was a problem hiding this comment.
I don't see a difference with the block of code above. Is #if NET451 required here?
| @@ -0,0 +1,8 @@ | |||
| namespace Tests | |||
| @@ -172,7 +172,7 @@ public void GetDatabaseName_Should_ReturnName() | |||
|
|
|||
| private static string GetBackupFilePath(String filename = "multiFileBackup.bak") | |||
| { | |||
| return Directory.GetFiles(AppDomain.CurrentDomain.BaseDirectory, filename, SearchOption.AllDirectories).FirstOrDefault(); | |||
| return Directory.GetFiles(Directory.GetCurrentDirectory(), filename, SearchOption.AllDirectories).FirstOrDefault(); | |||
|
I see not much code changes are actually required to get to .NetStandard. The biggest problem is with DacFx dependency, but it caused trouble before - see #18. I'll see what can be done about this. Ability to work with As for exception I get on build - this is due to lack of tooling installed - I need to update to the latest .Core tools, and even to VS2017. Exception on the build server is for packing nuget - folder structure generated by the new msbuild is different to what it was before, so |
|
I'm about to go on holidays. So please excuse the lack of responsiveness for a week-or-two. |
|
Closing due to lack of response |
Port to NetStandard v1.6
This is backward compatible with .NetFramework v4.5 and up
Will work with .NetCore apps