Improve collision handling on multiple create calls #2325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2324
PR adds logic for doing collision avoidance when calling the
create
command multiple times within the same second. Currently, all files would have the same timestamp, and then ordering would be based on the class name. With this PR, each subsequent call tocreate
will increment the timestamp prefix by N seconds until we get a unique timestamp. This is useful for directions that might have a user run multiplecreate
commands to scaffold their app.This is technically a backwards breaking change if someone relied on multiple calls to
create
at the same time to be ordered by classname, but I don't think that's likely, and so I'm not going to worry about it much.