Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Set important to override bootstrap h4 #2644

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

machikoyasuda
Copy link
Member

closes #2601

Bootstrap has a class called h4, which has different sizing than what we want.

I could have done a few things:

  • Rename the h4 class in our styles
  • Use this disable-rfs class that Bootstrap gives you
  • Or add important to the existing h4 size declaration

I decided to go with the latter, so that any future use of h4 will be covered (and not require the dev to know to use disable-rfs). I didn't want to rename all the hX classes.

@machikoyasuda machikoyasuda requested a review from a team as a code owner January 23, 2025 20:06
@machikoyasuda machikoyasuda self-assigned this Jan 23, 2025
@machikoyasuda machikoyasuda changed the title fix(css): use important to override bootstrap h4 Fix: Set important to override bootstrap h4 Jan 23, 2025
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Jan 23, 2025
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@angela-tran
Copy link
Member

angela-tran commented Jan 23, 2025

Did you find out anything about why it only happens on Chrome?

Oh, I remember now from the notes on #2603 that it has to do with responsive font sizing

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to reproduce the issue on Linux, so I can't test this myself. From that and the ticket description, I'm guessing that this is an macOS / Chrome - specific issue.

The reasoning for using !important sounds good to me.

@machikoyasuda machikoyasuda merged commit 462ab11 into main Jan 23, 2025
12 checks passed
@machikoyasuda machikoyasuda deleted the fix/2601-help-h4-rfs branch January 23, 2025 22:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Chrome - h4 class not working on Chrome
2 participants