Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: rename test route to testerror/ #2702

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix: rename test route to testerror/ #2702

merged 1 commit into from
Feb 25, 2025

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Feb 25, 2025

I needed this change while testing #2694.

In 746f322, we introduced an error/ route to core's URLconf. We overlooked that in the root URLconf, there already was an error/ route if DEBUG=True, which is for the purpose of testing Sentry.

That change was in May 2024, so I'm not sure how we've been able to test Sentry updates since then. For example, in November 2024, I was somehow able to hit the root error/ and trigger the RuntimeError("Test error").

Today, what I saw was that when I go to error/, I hit the core error/ and see the Error page. No Sentry notification is sent:

I had to change the route name to something else in order to hit the root path and then a Sentry notification was sent:

@angela-tran angela-tran self-assigned this Feb 25, 2025
@angela-tran angela-tran requested a review from a team as a code owner February 25, 2025 21:08
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits
  urls.py 51
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I haven't seen this problem before either 🤔

But I was able to confirm the problem, and this change matches our testsecret/ registration.

@angela-tran angela-tran merged commit dd66198 into main Feb 25, 2025
14 checks passed
@angela-tran angela-tran deleted the fix/test-error-url branch February 25, 2025 23:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants