This repository was archived by the owner on May 16, 2023. It is now read-only.
Use serde_dynamo for dynamodb::Event items
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
suggested changes
Mar 23, 2023
Absolutely! What sorts of tests would you like to see? Parsing from DynamoDB's JSON format to Or are there other aspects that would help increase confidence that this will work? |
|
I just added the existing |
calavera
approved these changes
Mar 23, 2023
calavera
reviewed
Mar 23, 2023
| @@ -139,6 +139,18 @@ where | |||
| Ok(opt.unwrap_or_default()) | |||
| } | |||
|
|
|||
| /// Deserializes `Item`, mapping JSON `null` to an empty item. | |||
| pub(crate) fn deserialize_lambda_dynamodb_item<'de, D>( | |||
There was a problem hiding this comment.
I think this code needs to be behind a feature flag. Otherwise, the library will fail to compile when dynamodb is not enabled.
calavera
suggested changes
Mar 23, 2023
Use `serde_dynamo::Item` instead of `HashMap<String, AttributeValue>` to represent the `keys`, `old_image`, and `new_image` in a `dynamodb::Event`. This consolidates the Rust/DynamoDB ecosystem around fewer representations of DynamoDB items. Note that `serde_dynamo::AttributeValue` and `aws_lambda_events::dynamodb::attributes::AttributeValue` are slightly different (especially with regards to the `Number` enumeration) so this is a breaking change that would either need to go behind a feature flag or a major version bump.
|
Changes in this most recent commit:
|
calavera
approved these changes
Mar 24, 2023
calavera
pushed a commit
that referenced
this pull request
Mar 24, 2023
Use `serde_dynamo::Item` instead of `HashMap<String, AttributeValue>` to represent the `keys`, `old_image`, and `new_image` in a `dynamodb::Event`. This consolidates the Rust/DynamoDB ecosystem around fewer representations of DynamoDB items. Note that `serde_dynamo::AttributeValue` and `aws_lambda_events::dynamodb::attributes::AttributeValue` are slightly different (especially with regards to the `Number` enumeration) so this is a breaking change that would either need to go behind a feature flag or a major version bump. (cherry picked from commit 50ce8ed) Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
added a commit
that referenced
this pull request
Mar 24, 2023
Use `serde_dynamo::Item` instead of `HashMap<String, AttributeValue>` to represent the `keys`, `old_image`, and `new_image` in a `dynamodb::Event`. This consolidates the Rust/DynamoDB ecosystem around fewer representations of DynamoDB items. Note that `serde_dynamo::AttributeValue` and `aws_lambda_events::dynamodb::attributes::AttributeValue` are slightly different (especially with regards to the `Number` enumeration) so this is a breaking change that would either need to go behind a feature flag or a major version bump. (cherry picked from commit 50ce8ed) Signed-off-by: David Calavera <david.calavera@gmail.com> Co-authored-by: Bryan Burgers <bryan@burgers.io>
jakubadamw
reviewed
May 1, 2023
| @@ -169,7 +29,7 @@ mod test { | |||
|
|
|||
| let attr: AttributeValue = serde_json::from_value(value.clone()).unwrap(); | |||
| match attr { | |||
| AttributeValue::String(ref s) => assert_eq!("value", s.as_str()), | |||
| AttributeValue::S(ref s) => assert_eq!("value", s.as_str()), | |||
There was a problem hiding this comment.
In my humble opinion this is a regression in readability. Fully spelled out variant names with the appropriate #[serde(rename = "…")] attributes seemed better.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
serde_dynamo::Iteminstead ofHashMap<String, AttributeValue>to represent thekeys,old_image, andnew_imagein adynamodb::Event.This consolidates the Rust/DynamoDB ecosystem around fewer representations of DynamoDB items.
Note that
serde_dynamo::AttributeValueandaws_lambda_events::dynamodb::attributes::AttributeValueare slightly different (especially with regards to theNumberenumeration) so this is a breaking change that would either need to go behind a feature flag or a major version bump.I feel like this might be of interest to the wider community because
dynamodb::Eventandserde_dynamoused together already, andserde_json, this helps prompt users to convert to a typed representation of their entity earlier.I'm curious whether you think this is useful for aws-lambda-events and the wider Rust+AWS ecosystem.