This repository was archived by the owner on May 16, 2023. It is now read-only.
Add default to http_serde::header_map::deserialize #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go SDK typically has
omitEmpty
for Rust'shttp::HeaderMap
entries, and services like ALB omit them when they're not present. However, without adefault
parameter to the#[serde()]
annotation, deserialization fails when they're missing instead of the desired behavior of producing an emptyHeaderMap
.This changes
#[serde(deserialize_with = "http_serde::header_map::deserialize")]
annotations to#[serde(deserialize_with = "http_serde::header_map::deserialize", default)]
so we get the desired behavior. A test is also added (inaws_lambda_events/src/custom_serde.rs
-- feel free to suggest a better place if there is one) to verify the correctness of this change.