This repository has been archived by the owner on May 16, 2023. It is now read-only.
Make alb and apigw stable #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules are stable, and we can add improvements without being tied to the generator. Signed-off-by: David Calavera <david.calavera@gmail.com>
Some fields use string vectors to group queries with the same key, while others use a single string separated by commas. QueryMap is a struct designed to handle those corner cases. Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
1 task
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts ApiGW and Alb from the generated modules, so we can stabilize them.
It introduces QueryMap to handle query parameters that normalizes their values under a single struct that knows how to handle Lambda's corner cases.
Now that they are not generated anymore, we can address issues like #13 and #49.