Skip to content

refactor(v13): a11y label helpers #1666

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Sep 12, 2024

Summary

Unify ARIA label and ARIA labelled by computation logic.

Test plan

  • Add relevant tests

@mdjastrzebski mdjastrzebski force-pushed the refactor/a11y-label-calculation branch 2 times, most recently from 9dc12dd to 853d3e9 Compare October 25, 2024 07:07
@mdjastrzebski mdjastrzebski marked this pull request as draft October 25, 2024 07:20
@mdjastrzebski mdjastrzebski force-pushed the refactor/a11y-label-calculation branch from 853d3e9 to 502cf6d Compare October 31, 2024 11:10
@mdjastrzebski mdjastrzebski changed the base branch from main to v13 October 31, 2024 11:10
@mdjastrzebski mdjastrzebski changed the title refactor: a11y label helpers refactor(v13): a11y label helpers Oct 31, 2024
@mdjastrzebski mdjastrzebski marked this pull request as ready for review November 5, 2024 08:05
@mdjastrzebski mdjastrzebski force-pushed the refactor/a11y-label-calculation branch from 9e9a477 to 05c4284 Compare November 5, 2024 08:07
@mdjastrzebski mdjastrzebski merged commit 83cafe4 into v13 Nov 5, 2024
8 checks passed
@mdjastrzebski mdjastrzebski deleted the refactor/a11y-label-calculation branch November 5, 2024 08:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant