Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add skip blur option #1704

Merged

Conversation

mrpmohiburrahman
Copy link
Contributor

Summary

Resolves: #1677

Test plan

All tests pass

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comment about events affected by this flag. Please add also documentation entry for the option.

src/user-event/type/type.ts Show resolved Hide resolved
@mrpmohiburrahman
Copy link
Contributor Author

I've left comment about events affected by this flag. Please add also documentation entry for the option.

Could you guide me on where to place the documentation entry for the skipBlur option?

@mdjastrzebski
Copy link
Member

Document to update: https://github.com/callstack/react-native-testing-library/blob/main/website/docs/12.x/docs/api/events/user-event.mdx.

Please also add units test(s) for behavior with skipBlur option set.

@mrpmohiburrahman
Copy link
Contributor Author

Document to update: https://github.com/callstack/react-native-testing-library/blob/main/website/docs/12.x/docs/api/events/user-event.mdx.

Please also add units test(s) for behavior with skipBlur option set.

Hi, @mdjastrzebski ,

I have updated doc and added unit test.
please, check.
Also note that, I am very new to this.

@mdjastrzebski mdjastrzebski force-pushed the mrp/feature/skip-blur-option branch from 2703b85 to ecb1014 Compare November 27, 2024 08:35
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (393d84c) to head (f879e14).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1704      +/-   ##
==========================================
+ Coverage   95.12%   95.16%   +0.03%     
==========================================
  Files          98       98              
  Lines        5603     5605       +2     
  Branches      589      590       +1     
==========================================
+ Hits         5330     5334       +4     
+ Misses        273      271       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski force-pushed the mrp/feature/skip-blur-option branch from 234f686 to f879e14 Compare November 27, 2024 08:44
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge! @mrpmohiburrahman thank you for this contribution.

@mdjastrzebski mdjastrzebski merged commit 1973cbc into callstack:main Nov 27, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support skipBlur in the type() user event
2 participants