-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add skip blur option #1704
feat: add skip blur option #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left comment about events affected by this flag. Please add also documentation entry for the option.
Could you guide me on where to place the documentation entry for the skipBlur option? |
Document to update: https://github.com/callstack/react-native-testing-library/blob/main/website/docs/12.x/docs/api/events/user-event.mdx. Please also add units test(s) for behavior with |
Hi, @mdjastrzebski , I have updated doc and added unit test. |
2703b85
to
ecb1014
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
==========================================
+ Coverage 95.12% 95.16% +0.03%
==========================================
Files 98 98
Lines 5603 5605 +2
Branches 589 590 +1
==========================================
+ Hits 5330 5334 +4
+ Misses 273 271 -2 ☔ View full report in Codecov by Sentry. |
234f686
to
f879e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge! @mrpmohiburrahman thank you for this contribution.
Summary
Resolves: #1677
Test plan
All tests pass