Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PIFO trees: better testing #1765

Merged
merged 23 commits into from
Nov 16, 2023
Merged

PIFO trees: better testing #1765

merged 23 commits into from
Nov 16, 2023

Conversation

anshumanmohan
Copy link
Contributor

This PR does the same treatment for PIFO trees that #1762 and #1763 do for FIFOs and PIFOs. That is, it:

  • Generates a .data file automatically.
  • Parses the .data file into Python and "runs" the PIFO tree regime as usual. Generates an .expect file.
  • And then these automatic .data and .expect files can be used by runt to test the eDSL code as usual.

You will need:

python calyx-py/calyx/queue_data_gen.py > calyx-py/test/correctness/pifo_tree.data

and

python calyx-py/calyx/queue_data_gen.py | python calyx-py/calyx/pifotree_oracle.py > calyx-py/test/correctness/pifo_tree.expect

This PR continues the OO style introduced in #1763: creating the tree is a cinch because a PIFO is just an object that manages two queues, and a "tree" just happens to manage PIFOs and not FIFOs.

@anshumanmohan anshumanmohan changed the base branch from master to pifo-better-testing November 8, 2023 18:05
@anshumanmohan anshumanmohan changed the title Pifotree better testing pifo tree: better testing Nov 8, 2023
Base automatically changed from pifo-better-testing to master November 16, 2023 21:10
@anshumanmohan anshumanmohan enabled auto-merge (squash) November 16, 2023 21:12
@anshumanmohan anshumanmohan merged commit 5160e84 into master Nov 16, 2023
@anshumanmohan anshumanmohan deleted the pifotree-better-testing branch November 16, 2023 21:26
@anshumanmohan anshumanmohan changed the title pifo tree: better testing PIFO trees: better testing Nov 16, 2023
rachitnigam pushed a commit that referenced this pull request Feb 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant